# HG changeset patch # User František Kučera # Date 1388260063 -3600 # Node ID 5a4dbe6f962cad935735838d2d89ef6995498764 # Parent 1399ac70a5bdee604acad0187feef34b2094c375 Type names in --types option are case insensitive diff -r 1399ac70a5bd -r 5a4dbe6f962c java/sql-dk/src/info/globalcode/sql/dk/CLIParser.java --- a/java/sql-dk/src/info/globalcode/sql/dk/CLIParser.java Sat Dec 28 20:36:29 2013 +0100 +++ b/java/sql-dk/src/info/globalcode/sql/dk/CLIParser.java Sat Dec 28 20:47:43 2013 +0100 @@ -46,11 +46,11 @@ for (String oneType : typesString.split(",")) { int sepatratorIndex = oneType.indexOf(TYPE_NAME_SEPARATOR); if (sepatratorIndex == -1) { - numberedTypes.add(getType(oneType)); + numberedTypes.add(getType(oneType.toUpperCase())); } else { String namePart = oneType.substring(0, sepatratorIndex).trim(); String typePart = oneType.substring(sepatratorIndex + TYPE_NAME_SEPARATOR.length(), oneType.length()); - namedTypes.put(namePart, getType(typePart)); + namedTypes.put(namePart, getType(typePart.toUpperCase())); } } break; diff -r 1399ac70a5bd -r 5a4dbe6f962c java/sql-dk/src/info/globalcode/sql/dk/InfoLister.java --- a/java/sql-dk/src/info/globalcode/sql/dk/InfoLister.java Sat Dec 28 20:36:29 2013 +0100 +++ b/java/sql-dk/src/info/globalcode/sql/dk/InfoLister.java Sat Dec 28 20:47:43 2013 +0100 @@ -113,6 +113,7 @@ data.add(new Object[]{sqlType.name(), sqlType.getCode()}); } printTable(formatter, header, data); + log.log(Level.INFO, "Type names in --types option are case insensitive"); } public void listDatabases() throws ConfigurationException, FormatterException { diff -r 1399ac70a5bd -r 5a4dbe6f962c java/sql-dk/src/info/globalcode/sql/dk/SQLType.java --- a/java/sql-dk/src/info/globalcode/sql/dk/SQLType.java Sat Dec 28 20:36:29 2013 +0100 +++ b/java/sql-dk/src/info/globalcode/sql/dk/SQLType.java Sat Dec 28 20:47:43 2013 +0100 @@ -25,6 +25,9 @@ */ public enum SQLType { + /** + * Names must be upper case – user input is also converted to upper case → case insensitive + */ BIT(Types.BIT), TINYINT(Types.TINYINT), SMALLINT(Types.SMALLINT),